Feature flag empty_index #1475
Merged
Feature flag empty_index #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasil-pashov
force-pushed
the
feature/feature_flag_empty_index
branch
from
55c0716 to
3f5f783
Compare
vasil-pashov
force-pushed
the
feature/feature_flag_empty_index
branch
from
3f5f783 to
2effe0c
Compare
vasil-pashov
force-pushed
the
feature/feature_flag_empty_index
branch
from
38adaf6 to
0e1f11c
Compare
alexowens90
requested changes
Apr 17, 2024
alexowens90
approved these changes
Apr 22, 2024
python/tests/unit/arcticdb/version_store/test_empty_column_type.py
Outdated
Show resolved
Hide resolved
added 3 commits
April 22, 2024 16:25
…ironment (pandas, nunpy, python)
vasil-pashov
added a commit
that referenced
this pull request
Apr 24, 2024
#### Reference Issues/PRs Relates to: #1429, #1440 #### What does this implement or fix? Feature flag the use of empty type. It uses the same library config option as the empty column type. In order to preserve behavior empty dataframes will use DataTimeIndex. #### Any other comments? #### Checklist <details> <summary> Checklist for code changes... </summary> - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [ ] Are API changes highlighted in the PR description? - [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes? </details> <!-- Thanks for contributing a Pull Request to ArcticDB! Please ensure you have taken a look at: - ArcticDB's Code of Conduct: https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md - ArcticDB's Contribution Licensing: https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing --> --------- Co-authored-by: Vasil Pashov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Relates to: #1429, #1440
What does this implement or fix?
Feature flag the use of empty type. It uses the same library config option as the empty column type. In order to preserve behavior empty dataframes will use DataTimeIndex.
Any other comments?
Checklist
Checklist for code changes...